jackye1995 commented on code in PR #8797: URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803785511
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -171,6 +171,16 @@ default RewriteDataFiles zOrder(String... columns) { */ RewriteDataFiles filter(Expression expression); + /** + * Specify the branch on which the rewrite will be performed. via WAP(write-audit-publish) Review Comment: I see, looks like WAP is supported through the procedure, but I don't think we need to mention it here in the RewriteDataFiles class, since that is a caller's logic to map WAP branch to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org