Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks merged PR #12250: URL: https://github.com/apache/iceberg/pull/12250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1981751859 ## core/src/main/java/org/apache/iceberg/TableUtil.java: ## @@ -30,6 +30,9 @@ public static int formatVersion(Table table) { if (table instanceof Serializab

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

nastra commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1975518509 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -200,7 +207,8 @@ static class PositionDeletesWriterFactory im

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1974017826 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -200,7 +207,8 @@ static class PositionDeletesWriterFact

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1974017826 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -200,7 +207,8 @@ static class PositionDeletesWriterFact

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

nastra commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1973052621 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -200,7 +207,8 @@ static class PositionDeletesWriterFactory im

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1972648555 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -200,7 +207,8 @@ static class PositionDeletesWriterFact

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

nastra closed pull request #12250: Spark: Rewrite V2 deletes to V3 DVs URL: https://github.com/apache/iceberg/pull/12250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1958620415 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -140,6 +148,33 @@ public RewritePositionDele

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1958620415 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -140,6 +148,33 @@ public RewritePositionDele

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

nastra commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1956228490 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWriterFactory

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

nastra commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1956220825 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -404,8 +408,31 @@ private void validateAndInitOpti

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

amogh-jahagirdar commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1955585866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWrit

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

amogh-jahagirdar commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1955585866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWrit

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1954910410 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java: ## @@ -213,45 +217,61 @@ static class PositionDeletesWriterFa

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1954884816 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -404,8 +408,31 @@ private void validateAndIn

Re: [PR] Spark: Rewrite V2 deletes to V3 DVs [iceberg]

danielcweeks commented on code in PR #12250: URL: https://github.com/apache/iceberg/pull/12250#discussion_r1954884816 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: ## @@ -404,8 +408,31 @@ private void validateAndIn