danielcweeks commented on code in PR #12250:
URL: https://github.com/apache/iceberg/pull/12250#discussion_r1972648555
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -200,7 +207,8 @@ static class PositionDeletesWriterFactory implements
DataWriterFactory {
StructType dsSchema,
int specId,
StructLike partition,
- Map<String, String> writeProperties) {
+ Map<String, String> writeProperties,
+ int formatVersion) {
Review Comment:
Couldn't we put the formatVersion in the `SerializableTable` or
`SerializableMetadataTable`? I think the would be more generally useful since
we may need that information for other use cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
