danielcweeks commented on code in PR #12250:
URL: https://github.com/apache/iceberg/pull/12250#discussion_r1981751859
##########
core/src/main/java/org/apache/iceberg/TableUtil.java:
##########
@@ -30,6 +30,9 @@ public static int formatVersion(Table table) {
if (table instanceof SerializableTable) {
SerializableTable serializableTable = (SerializableTable) table;
return serializableTable.formatVersion();
+ } else if (table instanceof PositionDeletesTable) {
+ PositionDeletesTable positionDeletesTable = (PositionDeletesTable) table;
Review Comment:
Can't we replace this with `BaseMetadataTable` and then we don't end up
being too specific here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
