nastra commented on code in PR #12250:
URL: https://github.com/apache/iceberg/pull/12250#discussion_r1975518509
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -200,7 +207,8 @@ static class PositionDeletesWriterFactory implements
DataWriterFactory {
StructType dsSchema,
int specId,
StructLike partition,
- Map<String, String> writeProperties) {
+ Map<String, String> writeProperties,
+ int formatVersion) {
Review Comment:
@danielcweeks I fully agree with everything you said. I think the only
caveat is that there isn't a direct 1:1 mapping for each metadata table to its
base table in terms of format version. This came already up in
https://github.com/apache/iceberg/pull/11587#discussion_r1848685646.
For now I've handled the format version only for the `PositionDeletesTable`
and we can re-visit the discussion about how we want to do it for the other
metadata tables. Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
