Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-03-13 Thread via GitHub
steveloughran commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2721144184 @mmgaggle I'm actually setting up the s3a tests to actually test through iceberg and parquet, so we can validate features and performance optimisations through our code. I

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-24 Thread via GitHub
mmgaggle commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2680003867 > > How hard would it be for us to get some integration tests with one of these systems into the Iceberg project? Seems like we should have some coverage for these other S3-Compat syst

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-24 Thread via GitHub
mmgaggle commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1968606398 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSett

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-24 Thread via GitHub
mmgaggle commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1968606398 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSett

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-21 Thread via GitHub
nk1506 commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2674329650 > How hard would it be for us to get some integration tests with one of these systems into the Iceberg project? Seems like we should have some coverage for these other S3-Compat

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-20 Thread via GitHub
RussellSpitzer commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2672695747 @ebyhr How hard would it be for us to get some integration tests with one of these systems into the Iceberg project? Seems like we should have some coverage for these other S3-Co

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
wendigo commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2669236427 @nastra that will work :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
nastra commented on PR #12264: URL: https://github.com/apache/iceberg/pull/12264#issuecomment-2669216427 I think we should revert the AWS SDK version (https://github.com/apache/iceberg/pull/12339) for 1.8.1 and then properly fix it for 1.9.0. @ebyhr does that make sense? -- This is an au

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1961489124 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -29,15 +29,18 @@ import software.amazon.awssdk.services.s3.S3ClientBuilder; public class MinioU

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1961489124 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -29,15 +29,18 @@ import software.amazon.awssdk.services.s3.S3ClientBuilder; public class MinioU

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
wendigo commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1961358048 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -29,15 +29,18 @@ import software.amazon.awssdk.services.s3.S3ClientBuilder; public class Mini

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-19 Thread via GitHub
nastra commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1961355014 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -29,15 +29,18 @@ import software.amazon.awssdk.services.s3.S3ClientBuilder; public class Minio

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-15 Thread via GitHub
wendigo commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1957256878 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSette

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-15 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955642546 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSetter.

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-14 Thread via GitHub
Fokko commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1956601588 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSetter.

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955642546 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSetter.

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955642546 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) { aclSetter.

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955600722 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) {

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955595821 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) {

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955595821 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) {

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-02-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955593603 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ## @@ -149,4 +151,10 @@ static void configurePermission( Function aclSetter) {