mmgaggle commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r1968606398
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java:
##########
@@ -149,4 +151,10 @@ static void configurePermission(
Function<ObjectCannedACL, S3Request.Builder> aclSetter) {
aclSetter.apply(s3FileIOProperties.acl());
}
+
+ // TODO Remove me once all of the S3-compatible storage support strong
integrity checks
+ @SuppressWarnings("deprecation")
+ static AwsRequestOverrideConfiguration disableStrongIntegrityChecksums() {
+ return
AwsRequestOverrideConfiguration.builder().signer(AwsS3V4Signer.create()).build();
Review Comment:
We added support in Ceph. There is a lot of places this can pop up in
PutObject, UploadPart, CompleteMultipartUpload, AWSv2 vs AWSv4 semantics, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
