ebyhr commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955642546
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java:
##########
@@ -149,4 +151,10 @@ static void configurePermission(
Function<ObjectCannedACL, S3Request.Builder> aclSetter) {
aclSetter.apply(s3FileIOProperties.acl());
}
+
+ // TODO Remove me once all of the S3-compatible storage support strong
integrity checks
+ @SuppressWarnings("deprecation")
+ static AwsRequestOverrideConfiguration disableStrongIntegrityChecksums() {
+ return
AwsRequestOverrideConfiguration.builder().signer(AwsS3V4Signer.create()).build();
Review Comment:
Setting `WHEN_REQUIRED` for checksum calculation/validation doesn't resolve
as far as I tested. Calculating MD5 for PutObjectRequest looks feasible, but
I'm not sure how to do it for DeleteObjectsRequest.
@wendigo Do you happen to know any other approaches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
