amogh-jahagirdar commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r1955595821
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java: ########## @@ -149,4 +151,10 @@ static void configurePermission( Function<ObjectCannedACL, S3Request.Builder> aclSetter) { aclSetter.apply(s3FileIOProperties.acl()); } + + // TODO Remove me once all of the S3-compatible storage support strong integrity checks Review Comment: I understand the intent but this doesn't feel like a great way of going about this just because there's many out there and "all" just seems like a moving goalpost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org