kevinjqliu commented on PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2489368811
opened #1349 and added back the warning filter, we can remove once we
upgrade PySpark to 4.0
--
This is an automated message from the Apache Git Service.
To respond to the mes
kevinjqliu commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850949666
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
kevinjqliu commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850960337
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
kevinjqliu merged PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850952486
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
Fokko commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850887791
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
kevinjqliu commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850862507
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
kevinjqliu commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850859511
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
kevinjqliu commented on PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2489333916
`datetime.datetime.utcfromtimestamp` is deprecated starting from 3.12
https://docs.python.org/3.12/library/datetime.html#datetime.datetime.utcfromtimestamp
--
This is
Fokko commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850845518
##
pyiceberg/table/__init__.py:
##
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
Fokko commented on PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2489346149
@kevinjqliu Yes a newer version of Python will emit a deprecation warning,
I'm okay with putting back the exclusion to fix that in another PR
--
This is an automated message from t
kevinjqliu commented on PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2489315506
super weird that this is only happening to 3.12
```
self = TimestampNTZType(), ts = 16726011
def fromInternal(self, ts: int) -> datetime.datetime:
sungwy commented on PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2488661073
Hi @kevinjqliu thanks for bouncing on this! And nice catch on the
`commit_table` functions... this looks good to me. It looks like python3.12 CI
is failing due to a DeprecationWarni
13 matches
Mail list logo
