Fokko commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850845518
##########
pyiceberg/table/__init__.py:
##########
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
"""
- return self.identifier
+ return self._identifier
Review Comment:
I think this change is problematic since we change the contract here.
Everyone that's using 8.0.0 expects the catalog to be part of the name, with
his change we remove that one without letting the user know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
