kevinjqliu commented on PR #1346: URL: https://github.com/apache/iceberg-python/pull/1346#issuecomment-2489315506
super weird that this is only happening to 3.12 ``` self = TimestampNTZType(), ts = 1672601100000000 def fromInternal(self, ts: int) -> datetime.datetime: if ts is not None: # using int to avoid precision loss in float > return datetime.datetime.utcfromtimestamp(ts // 1000000).replace( microsecond=ts % 1000000 ) E DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). ``` which corresponds to pyspark's use of `datetime.datetime.utcfromtimestamp`, which was recently changed https://github.com/apache/spark/commit/8e02a6493ef5dc5949e161179a7c081c5ca58ff2#diff-bb02965370d515ec7add7967bc949c18c88ffc7346cceaebefb84907dfdce903L437 We remove the warning in #1134, but the tests passed then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org