Fokko commented on code in PR #1346:
URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850887791
##########
pyiceberg/table/__init__.py:
##########
@@ -801,7 +801,7 @@ def name(self) -> Identifier:
Returns:
An Identifier tuple of the table name
"""
- return self.identifier
+ return self._identifier
Review Comment:
Yes, that would be the correct way. I don't see any other option to just
accept this. Since the `.name()` is just new, I think it is acceptable, but we
probably should call it out at the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
