Fokko commented on code in PR #1346: URL: https://github.com/apache/iceberg-python/pull/1346#discussion_r1850952486
########## pyiceberg/table/__init__.py: ########## @@ -801,7 +801,7 @@ def name(self) -> Identifier: Returns: An Identifier tuple of the table name """ - return self.identifier + return self._identifier Review Comment: Deprecating it seems like a lot of work, and will also be confusing to the end-user. So I don't think we have many options, and I think what you're suggesting in this PR is the best path forward. Getting this out ASAP in 0.8.1 would be great 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org