Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-30 Thread via GitHub
sungwy commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2843873261 Thanks for the review @flyrain and @dimas-b ! 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-30 Thread via GitHub
sungwy commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2843872705 Merging it in :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-30 Thread via GitHub
sungwy merged PR #12376: URL: https://github.com/apache/iceberg/pull/12376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-30 Thread via GitHub
dimas-b commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2843750317 @flyrain : feel free to merge (I was basically waiting for second opinions after my approval :slightly_smiling_face: ) -- This is an automated message from the Apache Git Service. To

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-30 Thread via GitHub
flyrain commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2843658931 Hi @sungwy, thanks for the reply. I'm OK with moving forward with this PR. We could deprecate it in a followup one. -- This is an automated message from the Apache Git Service. To re

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-26 Thread via GitHub
sungwy commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2832831939 > Hi @sungwy, are you still working on it? Hi @flyrain I'm still waiting on an approval to merge this in. Is the direction that we want to make it more clear that we are dep

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-26 Thread via GitHub
flyrain commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2832630055 Hi @sungwy, are you still working on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-04-25 Thread via GitHub
github-actions[bot] commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2831648069 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-03-26 Thread via GitHub
sungwy commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r2014648551 ## open-api/rest-catalog-open-api.yaml: ## @@ -4458,7 +4458,9 @@ components: # The fields `message` and `type` as indicated here are not presently prescriptive.

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-03-07 Thread via GitHub
flyrain commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1985522848 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-28 Thread via GitHub
flyrain commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1976113681 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-27 Thread via GitHub
sungwy commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1974643193 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-27 Thread via GitHub
sungwy commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1974643193 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-27 Thread via GitHub
flyrain commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1974452617 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-27 Thread via GitHub
dimas-b commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1973840064 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-26 Thread via GitHub
sungwy commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1972692336 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-26 Thread via GitHub
flyrain commented on code in PR #12376: URL: https://github.com/apache/iceberg/pull/12376#discussion_r1972482202 ## open-api/rest-catalog-open-api.yaml: ## @@ -4566,7 +4568,9 @@ components: AuthenticationTimeoutResponse: description: -Credentials have timed

Re: [PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-25 Thread via GitHub
sungwy commented on PR #12376: URL: https://github.com/apache/iceberg/pull/12376#issuecomment-2683707993 > Thanks for the spec clarification, @sungwy ! The changes LGTM πŸ‘ All thanks to you for the helpful reviews @dimas-b πŸ’― -- This is an automated message from the Apache Git Servic

[PR] OpenAPI: Use more clear language in recommending error responses [iceberg]

2025-02-22 Thread via GitHub
sungwy opened a new pull request, #12376: URL: https://github.com/apache/iceberg/pull/12376 The existence of the 419 AuthenticationTimeoutResponse status code caused confusion in the Iceberg community on the following two questions: - whether the error response should be issued by a REST