sungwy commented on code in PR #12376:
URL: https://github.com/apache/iceberg/pull/12376#discussion_r1974643193
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4566,7 +4568,9 @@ components:
AuthenticationTimeoutResponse:
description:
- Credentials have timed out. If possible, the client should refresh
credentials and retry.
+ This is an optional status response type that the REST Catalog can
issue when the
+ token has expired. The client MAY request a new access token and retry
the request.
+ 401 UnauthorizedResponse SHOULD be preferred over this response type
on token expiry.
Review Comment:
> To retry or not is the client side decision
Yes I agree with you @flyrain . Although I think it'll be confusing for
application developers if for example, [PyIceberg removed retry handling for
419
status](https://github.com/apache/iceberg-python/blob/bdb7c7d265322ab135e29a98166dd79eb737dcba/pyiceberg/catalog/rest.py#L151C38-L151C63)
on the next version after the 419 status code is deprecated on the REST
Catalog. The application developer would expect 419 status codes from their
REST Catalog server to result in retries, and on version upgrade they their
PyIceberg application no longer will. Hence, as a community, we may need to
keep 419 status code handling for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
