flyrain commented on code in PR #12376:
URL: https://github.com/apache/iceberg/pull/12376#discussion_r1974452617
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4566,7 +4568,9 @@ components:
AuthenticationTimeoutResponse:
description:
- Credentials have timed out. If possible, the client should refresh
credentials and retry.
+ This is an optional status response type that the REST Catalog can
issue when the
+ token has expired. The client MAY request a new access token and retry
the request.
+ 401 UnauthorizedResponse SHOULD be preferred over this response type
on token expiry.
Review Comment:
> may cause confusion as 419 responses from Iceberg REST Catalog servers
that are running on older versions of the spec won't be handled as expected.
Can you elaborate it? I think the clients are OK to treat a 419 as a 401, or
just a normal failure in that case. To retry or not is the client side
decision. I believe either behavior(client retry or not retry) is acceptable.
My only concern to deprecate it is the SigV4 use case @danielcweeks and @rdblue
mentioned, if SigV4 clients must depend on 419, we need to keep it. But I don't
have much context, will appreciate any inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
