sungwy commented on code in PR #12376:
URL: https://github.com/apache/iceberg/pull/12376#discussion_r1972692336
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4566,7 +4568,9 @@ components:
AuthenticationTimeoutResponse:
description:
- Credentials have timed out. If possible, the client should refresh
credentials and retry.
+ This is an optional status response type that the REST Catalog can
issue when the
+ token has expired. The client MAY request a new access token and retry
the request.
+ 401 UnauthorizedResponse SHOULD be preferred over this response type
on token expiry.
Review Comment:
Thank @flyrain !
Yeah I was actually debating on the last line, but decided to keep it to
facilitate this discussion. I believe a deprecation would result in us removing
the status code in a subsequent release, after which the status code handling
*could* also be removed from the Iceberg REST client representations which I
think may cause confusion as 419 responses from Iceberg REST Catalog servers
that are running on older versions of the spec won't be handled as expected.
Hence, I'm hesitant to suggest deprecating the status code.
I still think it's still fair to express a preference as we did here, so as
to not confuse the REST Catalog server implementer on which status code to
choose to use on token expiry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
