flyrain commented on code in PR #12376:
URL: https://github.com/apache/iceberg/pull/12376#discussion_r1976113681
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4566,7 +4568,9 @@ components:
AuthenticationTimeoutResponse:
description:
- Credentials have timed out. If possible, the client should refresh
credentials and retry.
+ This is an optional status response type that the REST Catalog can
issue when the
+ token has expired. The client MAY request a new access token and retry
the request.
+ 401 UnauthorizedResponse SHOULD be preferred over this response type
on token expiry.
Review Comment:
> The application developer would expect 419 status codes from their REST
Catalog server to result in retries
yeah, that's an edge case, in which a server happened to return 419, plus an
application happened to rely on 419 for retrying. As we all agreed that
419-based retry is not reliable and not recommended, application shouldn't do
that afterward. These are very subtle things though. I'm fine with not
deprecate it, but I still prefer to give users more clear message, that 419
shouldn't be used. Deprecating it makes it more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
