liurenjie1024 merged PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
sdd commented on PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1982809816
@Fokko are you able to take a look at this one yet please? 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sdd commented on PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1975882804
Ok @liurenjie1024 @Xuanwo and @ZENOTME, I've addressed the feedback and it's
ready to review again. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510673592
##
crates/iceberg/src/scan.rs:
##
@@ -163,24 +164,32 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+pub async fn execute(
+&self,
sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510673318
##
crates/iceberg/src/scan.rs:
##
@@ -445,4 +494,22 @@ mod tests {
format!("{}/3.parquet", &fixture.table_location)
);
}
+
+#[tokio::test]
liurenjie1024 commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510666374
##
crates/iceberg/src/scan.rs:
##
@@ -163,24 +164,32 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+pub async fn execute(
+
sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510659973
##
crates/iceberg/src/file_record_batch_reader.rs:
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510658654
##
crates/iceberg/src/scan.rs:
##
@@ -163,24 +164,32 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+pub async fn execute(
+&self,
liurenjie1024 commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508603649
##
crates/iceberg/src/scan.rs:
##
@@ -445,4 +494,22 @@ mod tests {
format!("{}/3.parquet", &fixture.table_location)
);
}
+
+#[to
liurenjie1024 commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508594423
##
crates/iceberg/src/file_record_batch_reader.rs:
##
Review Comment:
Given that most of these operations are arrow related, how about rename this
file i
Xuanwo commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508403764
##
crates/iceberg/src/io.rs:
##
@@ -215,9 +216,12 @@ pub struct InputFile {
}
/// Trait for reading file.
-pub trait FileRead: AsyncRead + AsyncSeek {}
+pub trait
ZENOTME commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508400754
##
crates/iceberg/src/io.rs:
##
@@ -215,9 +216,12 @@ pub struct InputFile {
}
/// Trait for reading file.
-pub trait FileRead: AsyncRead + AsyncSeek {}
+pub trai
sdd commented on PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1972211944
Woohoo, made the error handling much nicer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
13 matches
Mail list logo
