liurenjie1024 commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510666374
##########
crates/iceberg/src/scan.rs:
##########
@@ -163,24 +164,32 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+ pub async fn execute(
+ &self,
+ batch_size: Option<usize>,
Review Comment:
Yes, you are right. `TableScan` is used to define scan related args, such as
filter, snapshot, while `batch_size` is mostly execution related, so it's
appropriate to associate it with `ArrowReader`. The problem is with this api is
that it's not extensible, since we need to break it every time we add a new
config option for `ArrowReader`. How about removing this api, but passing
`TableScan` to `ArrowReaderBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
