sdd commented on code in PR #207: URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510659973
########## crates/iceberg/src/file_record_batch_reader.rs: ########## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Parquet file data reader + +use async_stream::try_stream; +use futures::stream::StreamExt; +use parquet::arrow::{ParquetRecordBatchStreamBuilder, ProjectionMask}; + +use crate::io::FileIO; +use crate::scan::{ArrowRecordBatchStream, FileScanTask, FileScanTaskStream}; +use crate::spec::SchemaRef; + +/// Default arrow record batch size +const DEFAULT_BATCH_SIZE: usize = 1024; + +/// Reads data from Parquet files +pub struct FileRecordBatchReader { + batch_size: Option<usize>, + #[allow(dead_code)] + schema: SchemaRef, + file_io: FileIO, +} + +impl FileRecordBatchReader { + /// Constructs a new FileRecordBatchReader + pub fn new(file_io: FileIO, schema: SchemaRef, batch_size: Option<usize>) -> Self { Review Comment: I can if you really think that's best, but that feels quite heavy when there is only one parameter that is optional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
