sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1510658654
##########
crates/iceberg/src/scan.rs:
##########
@@ -163,24 +164,32 @@ impl TableScan {
Ok(iter(file_scan_tasks).boxed())
}
+
+ pub async fn execute(
+ &self,
+ batch_size: Option<usize>,
Review Comment:
I can do this, but I wasn't sure that made sense, since `batch_size` might
be only relevant for `TableScanBuilder`'s whose `to_arrow()` method get called?
Will we have other methods on here equivalent to `to_arrow()` but returning
different types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
