aokolnychyi commented on PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#issuecomment-2465303918
Thanks for reviewing, @jbonofre @nastra @danielcweeks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
aokolnychyi merged PR #11481:
URL: https://github.com/apache/iceberg/pull/11481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1834763283
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema pro
nastra commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1834137964
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema projecti
jbonofre commented on PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#issuecomment-2464241405
@aokolnychyi Thanks for this great work ! I prefer this PR over #11486 :
imho, this impl is more "straight forward".
--
This is an automated message from the Apache Git Service.
To r
jbonofre commented on code in PR #11486:
URL: https://github.com/apache/iceberg/pull/11486#discussion_r1834016483
##
data/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##
@@ -42,4 +42,14 @@ public interface DeleteLoader {
* @return a position delete index for the
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1833847228
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema pro
aokolnychyi commented on code in PR #11486:
URL: https://github.com/apache/iceberg/pull/11486#discussion_r1833801076
##
data/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##
@@ -42,4 +42,14 @@ public interface DeleteLoader {
* @return a position delete index for t
aokolnychyi closed pull request #11486: Core: Support DVs in DeleteLoader
URL: https://github.com/apache/iceberg/pull/11486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
danielcweeks commented on code in PR #11486:
URL: https://github.com/apache/iceberg/pull/11486#discussion_r1833445653
##
data/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##
@@ -42,4 +42,14 @@ public interface DeleteLoader {
* @return a position delete index for
aokolnychyi commented on PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#issuecomment-2463277936
@nastra @danielcweeks @jbonofre, what do you folks think about #11486 as an
alternative implementation? Am I overcomplicating or is that one cleaner?
--
This is an automated messa
jbonofre commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1832918196
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema projec
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1832249335
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1832195417
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
danielcweeks commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831802198
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Ove
danielcweeks commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831797637
##
data/src/test/java/org/apache/iceberg/io/TestDVWriters.java:
##
@@ -100,6 +114,211 @@ public void testBasicDVs() throws IOException {
.contains(dataF
danielcweeks commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831795720
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema pr
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831747517
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema pro
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831746989
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema pro
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831735172
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831746215
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831737522
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831735172
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831735172
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -146,6 +151,26 @@ private Iterable materialize(CloseableIterable
iterable) {
@Over
aokolnychyi opened a new pull request, #11481:
URL: https://github.com/apache/iceberg/pull/11481
This PR adds support for reading DVs in `BaseDeleteLoader`, the only loader
implementation we have.
This work is part of #11122.
--
This is an automated message from the Apache Git Serv
25 matches
Mail list logo
