danielcweeks commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831802198
##########
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##########
@@ -146,6 +151,26 @@ private <T> Iterable<T> materialize(CloseableIterable<T>
iterable) {
@Override
public PositionDeleteIndex loadPositionDeletes(
Iterable<DeleteFile> deleteFiles, CharSequence filePath) {
+ if (containsDVs(deleteFiles)) {
Review Comment:
The `containsDVs` check here seems more broad than the assumption that there
is one and only one DV. Should we make the contains check assert those
expectations? (e.g. `containsSingleDV`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
