aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831746989
##########
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##########
@@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile,
Schema projection) {
private int estimateRecordSize(Schema schema) {
return schema.columns().stream().mapToInt(TypeUtil::estimateSize).sum();
}
+
+ private boolean containsDVs(Iterable<DeleteFile> deleteFiles) {
+ return Iterables.any(deleteFiles, ContentFileUtil::isDV);
+ }
+
+ private void validateDV(DeleteFile dv, CharSequence filePath) {
+ Preconditions.checkArgument(
+ dv.contentOffset() != null,
+ "Invalid DV, offset cannot be null: %s",
Review Comment:
@nastra, I updated these error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
