danielcweeks commented on code in PR #11486:
URL: https://github.com/apache/iceberg/pull/11486#discussion_r1833445653
##########
data/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##########
@@ -42,4 +42,14 @@ public interface DeleteLoader {
* @return a position delete index for the provided data file path
*/
PositionDeleteIndex loadPositionDeletes(Iterable<DeleteFile> deleteFiles,
CharSequence filePath);
+
+ /**
+ * Loads the content of the deletion vector into a position index.
+ *
+ * @param dv a deletion vector
+ * @return a position delete index for the provided deletion vector
+ */
+ default PositionDeleteIndex loadDV(DeleteFile dv) {
Review Comment:
I think I prefer #11481. This just feels like an unnecessary differentiation
of an implementation that we can hide under the existing interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
