aokolnychyi commented on code in PR #11481:
URL: https://github.com/apache/iceberg/pull/11481#discussion_r1831737522
##########
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##########
@@ -146,6 +151,26 @@ private <T> Iterable<T> materialize(CloseableIterable<T>
iterable) {
@Override
public PositionDeleteIndex loadPositionDeletes(
Iterable<DeleteFile> deleteFiles, CharSequence filePath) {
+ if (containsDVs(deleteFiles)) {
+ DeleteFile dv = Iterables.getOnlyElement(deleteFiles);
+ validateDV(dv, filePath);
+ return readDV(dv); // TODO: support caching entire DV files
+ } else {
+ return getOrReadPosDeletes(deleteFiles, filePath);
+ }
+ }
+
+ private PositionDeleteIndex readDV(DeleteFile dv) {
+ LOG.trace("Opening DV file {}", dv.location());
+ InputFile inputFile = loadInputFile.apply(dv);
+ long offset = dv.contentOffset();
+ int length = dv.contentSizeInBytes().intValue();
Review Comment:
The cast is safe as it is covered by `validateDV`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
