hantangwangd commented on PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#issuecomment-2657960091
@RussellSpitzer my pleasure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
RussellSpitzer commented on PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#issuecomment-2657564295
Thanks @hantangwangd for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
RussellSpitzer merged PR #12201:
URL: https://github.com/apache/iceberg/pull/12201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1955038335
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -233,6 +233,8 @@ public static List
mergeTasks(List tasks) {
}
public static lo
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1955038689
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -57,7 +60,10 @@ protected static Object[][] parameters() {
{
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1954977506
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -57,7 +60,10 @@ protected static Object[][] parameters() {
{
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1954976117
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -233,6 +233,8 @@ public static List
mergeTasks(List tasks) {
}
public static
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1950079317
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -57,7 +60,10 @@ protected static Object[][] parameters() {
{
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1950073181
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -233,6 +233,8 @@ public static List
mergeTasks(List tasks) {
}
public static lo
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1950014100
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##
@@ -57,7 +60,10 @@ protected static Object[][] parameters() {
{
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1949883612
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -233,6 +233,8 @@ public static List
mergeTasks(List tasks) {
}
public static
hantangwangd commented on PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#issuecomment-2648766365
Hi @RussellSpitzer, I have changed the code to check and uniformly throw an
error when splitSize is less than or equal to 0, and adjust the relevant tests
according to this behavio
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947986708
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, long
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947986708
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, long
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947961340
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, lo
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947961173
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, lo
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947899223
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, long
RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947861228
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, lo
hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947556326
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,8 +236,12 @@ public static long adjustSplitSize(long scanSize, int
parallelism, lon
manuzhang commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947553534
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -236,8 +236,12 @@ public static long adjustSplitSize(long scanSize, int
parallelism, long s
hantangwangd opened a new pull request, #12201:
URL: https://github.com/apache/iceberg/pull/12201
Currently, `TableScanUtil.adjustSplitSize(...)` can appropriately handle the
situations where parameter `splitSize` is negative, however, it doesn't
consider the situation where `splitSize` equ
21 matches
Mail list logo
