hantangwangd commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1950079317


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -57,7 +60,10 @@ protected static Object[][] parameters() {
       {
         SparkCatalogConfig.HIVE.catalogName(),
         SparkCatalogConfig.HIVE.implementation(),
-        SparkCatalogConfig.HIVE.properties(),
+        ImmutableMap.builder()

Review Comment:
   If we enable the cache in hive catalog (which is the default behavior), we 
cannot get the newest table metadata when executing a query closely after the 
action of setting table properties. In this case, in our test, the query 
`sql("SELECT * FROM %s", tableName)` will succeed after 
`table.updateProperties().set(SPLIT_SIZE, "-1").commit()`, that's not the 
expected behavior.
   
   So I disabled the cache for hive catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to