RussellSpitzer commented on code in PR #12201:
URL: https://github.com/apache/iceberg/pull/12201#discussion_r1947961173
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -236,6 +236,9 @@ public static long adjustSplitSize(long scanSize, int
parallelism, long splitSiz
// use the configured split size if it produces at least one split per slot
// otherwise, adjust the split size to target parallelism with a
reasonable minimum
// increasing the split size may cause expensive spills and is not done
automatically
+ if (splitSize <= 0) {
Review Comment:
The general rule of thumb has been that we generally try not to throw errors
on reading things out of metadata.json to avoid bricking on a metadata.json
written by bad writer. This shouldn't be the case here since the metadata.json
will parse correctly, but the invalid parameters would throw an error at
runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
