Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2025-01-07 Thread via GitHub
nastra merged PR #11064: URL: https://github.com/apache/iceberg/pull/11064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-12-25 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2562034661 Rebased on main branch to resolve conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-12-25 Thread via GitHub
github-actions[bot] commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2562033317 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-25 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1856267114 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -637,6 +637,30 @@ public void testCompleteCreateTable() { .isEqualTo(UUID.fromString(

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-25 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1856267114 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -637,6 +637,30 @@ public void testCompleteCreateTable() { .isEqualTo(UUID.fromString(

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-24 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1855997389 ## core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java: ## @@ -637,6 +637,30 @@ public void testCompleteCreateTable() { .isEqualTo(UUID.fromString

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-24 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1855449851 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identif

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-18 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1846005241 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identi

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-15 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1843906444 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identi

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-15 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1843788190 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -127,6 +127,36 @@ public void basicCreateView() { assertThat(catalog().viewExists(ident

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-15 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1843786671 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -127,6 +127,36 @@ public void basicCreateView() { assertThat(catalog().viewExists(ident

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-15 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1843786109 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -127,6 +127,36 @@ public void basicCreateView() { assertThat(catalog().viewExists(ident

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-15 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1843780475 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -871,6 +901,7 @@ public void createOrReplaceView(boolean useCreateOrReplace) { assert

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1842199190 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identif

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841867535 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -94,6 +96,11 @@ public void initialize(String name, Map properties) { closeableGrou

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841890539 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -79,6 +81,8 @@ protected BaseViewBuilder(TableIdentifier identifier) { Precon

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841887298 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identi

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841881702 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -1200,6 +1200,8 @@ private RESTViewBuilder(SessionContext context, TableIdentifier identi

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-14 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841877304 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +107,7 @@ public void basicCreateView() { assertThat(view.currentVersion().opera

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840963359 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +107,7 @@ public void basicCreateView() { assertThat(view.currentVersion

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840963359 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +107,7 @@ public void basicCreateView() { assertThat(view.currentVersion

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840963359 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +107,7 @@ public void basicCreateView() { assertThat(view.currentVersion

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840945935 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -85,6 +86,7 @@ public String name() { @Override public void initialize(Stri

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840946761 ## core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java: ## @@ -94,6 +96,11 @@ public void initialize(String name, Map properties) { close

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840938983 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -29,6 +29,7 @@ private CatalogProperties() {} public static final String WAREHOUSE_LO

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-12 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2472604215 @nastra Yes, I was actually waiting for next review round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-12 Thread via GitHub
nastra commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2472590892 @ebyhr are you still working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-11-12 Thread via GitHub
github-actions[bot] commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2471994274 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

[PR] Core: Add support for view-default property in catalog [iceberg]

2024-09-24 Thread via GitHub
nk1506 opened a new pull request, #11200: URL: https://github.com/apache/iceberg/pull/11200 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-12 Thread via GitHub
ebyhr commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1757698066 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -85,7 +85,8 @@ static RESTCatalog initCatalogClient() { catalogProperties.putIfAbsen

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-12 Thread via GitHub
nk1506 commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1756984629 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -29,6 +29,7 @@ private CatalogProperties() {} public static final String WAREHOUSE_LOCATION =

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-09 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1750255921 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -107,6 +108,7 @@ public void basicCreateView() { assertThat(view.currentVersion().opera

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-09 Thread via GitHub
nastra commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1750254414 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -85,7 +85,8 @@ static RESTCatalog initCatalogClient() { catalogProperties.putIfAbse

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-03 Thread via GitHub
singhpk234 commented on code in PR #11064: URL: https://github.com/apache/iceberg/pull/11064#discussion_r1742360146 ## docs/docs/spark-configuration.md: ## @@ -77,6 +77,8 @@ Both catalogs are configured using properties nested under the catalog name. Com | spark.sql.catalog._c

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-02 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2325282952 @RussellSpitzer Can you review this PR when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-02 Thread via GitHub
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2324566532 CI hit https://github.com/apache/iceberg/issues/10172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Core: Add support for `view-default` property in catalog [iceberg]

2024-09-01 Thread via GitHub
ebyhr opened a new pull request, #11064: URL: https://github.com/apache/iceberg/pull/11064 Fixes #10822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma