nastra commented on code in PR #11064:
URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841890539
##########
core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java:
##########
@@ -79,6 +81,8 @@ protected BaseViewBuilder(TableIdentifier identifier) {
Preconditions.checkArgument(
isValidIdentifier(identifier), "Invalid view identifier: %s",
identifier);
this.identifier = identifier;
+ this.properties.putAll(
Review Comment:
we might want to do it similarly to
https://github.com/apache/iceberg/blob/817a5e1be1616af77329965ac3742c14ca3ae116/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L258-L270
so that we have some logging when those defaults are set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
