RussellSpitzer commented on code in PR #11064:
URL: https://github.com/apache/iceberg/pull/11064#discussion_r1840945935
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -85,6 +86,7 @@ public String name() {
@Override
public void initialize(String name, Map<String, String> properties) {
this.catalogName = name != null ? name :
InMemoryCatalog.class.getSimpleName();
+ this.catalogProperties = ImmutableMap.copyOf(properties);
Review Comment:
Carefule here, ImmutableMap.copyOf isn't nullsafe
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -85,6 +86,7 @@ public String name() {
@Override
public void initialize(String name, Map<String, String> properties) {
this.catalogName = name != null ? name :
InMemoryCatalog.class.getSimpleName();
+ this.catalogProperties = ImmutableMap.copyOf(properties);
Review Comment:
Careful here, ImmutableMap.copyOf isn't null safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
