nastra commented on code in PR #11064:
URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841877304
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -107,6 +107,7 @@ public void basicCreateView() {
assertThat(view.currentVersion().operation()).isEqualTo("create");
assertThat(view.schemas()).hasSize(1).containsKey(0);
assertThat(view.versions()).hasSize(1).containsExactly(view.currentVersion());
+ assertThat(view.properties()).containsEntry("key1",
"catalog-default-key1");
Review Comment:
I would rather just add a new test method that specifically tests for
default properties (instead of adding these checks to existing tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
