nastra commented on code in PR #11064:
URL: https://github.com/apache/iceberg/pull/11064#discussion_r1841867535
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -94,6 +96,11 @@ public void initialize(String name, Map<String, String>
properties) {
closeableGroup.setSuppressCloseFailure(true);
}
+ @Override
+ protected Map<String, String> properties() {
+ return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
Review Comment:
I think this is still needed in case `initialize()` hasn't been called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]