findepi commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2439395678
thank you @tomtongue for your work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tomtongue commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2417064056
Thanks so much for the review! @nastra @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nastra merged PR #11262:
URL: https://github.com/apache/iceberg/pull/11262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2415996921
@findepi would you like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1802491767
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1802488056
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch ex
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1802487746
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch ex
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1802483572
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch ex
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800721063
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java:
##
@@ -43,6 +43,8 @@ public static void startMetastoreAndS
tomtongue commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2414157721
@nastra Reflected your review. Could you review new changes when you have a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1801225247
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800718584
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800744929
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800732927
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameterVal
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800718584
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800721063
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java:
##
@@ -43,6 +43,8 @@ public static void startMetastoreAndS
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800718584
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800718584
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800706912
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java:
##
@@ -43,6 +43,8 @@ public static void startMetastoreAndSpar
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800706543
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameter
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800693298
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -225,7 +222,11 @@ private Stream
createContextForParameters(
Stream parameterVal
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1799596701
##
spark/v3.5/build.gradle:
##
@@ -303,6 +310,11 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
description = "Test Spark
tomtongue commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2410285393
Thank you for taking a look at this! (Sorry I just sent the commit) Let me
reflect your comment.
--
This is an automated message from the Apache Git Service.
To respond to the messa
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1798898667
##
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##
@@ -73,13 +73,10 @@ public Stream
provideTestTemplateInvocationContex
// Search metho
nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1798896293
##
spark/v3.5/build.gradle:
##
@@ -303,6 +310,11 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
description = "Test Spark3 R
nastra commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2410267744
> Do you think it's a good idea if I change ParamerizedTest as you
suggested, and also add the legacy mode flag to Spark?
I took a closer look to see why this happens. It turns out
tomtongue commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2408149842
@nastra Thanks for looking into this. When I tried the change, the
`@Parameters` annotation in an inherited classe is basically used, so this
change can solve the error (for the `@Par
nastra commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2407180732
Rather than changing stuff everywhere, I'd probably consider changing how we
look up parameter providers:
```
--- a/api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.j
tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1794954223
##
flink/v1.18/build.gradle:
##
@@ -255,6 +260,11 @@
project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
description = "Test Flink Runtime
29 matches
Mail list logo
