nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1798898667
##########
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##########
@@ -73,13 +73,10 @@ public Stream<TestTemplateInvocationContext>
provideTestTemplateInvocationContex
// Search method annotated with @Parameters
final List<Method> parameterProviders =
AnnotationSupport.findAnnotatedMethods(
- context.getRequiredTestClass(), Parameters.class,
HierarchyTraversalMode.TOP_DOWN);
+ context.getRequiredTestClass(), Parameters.class,
HierarchyTraversalMode.BOTTOM_UP);
Review Comment:
```
@@ -225,7 +222,11 @@ public class ParameterizedTestExtension implements
TestTemplateInvocationContext
Stream<Object[]> parameterValueStream, String testNameTemplate,
ExtensionContext context) {
// Search fields annotated by @Parameter
final List<Field> parameterFields =
-
AnnotationSupport.findAnnotatedFields(context.getRequiredTestClass(),
Parameter.class);
+ AnnotationSupport.findAnnotatedFields(
+ context.getRequiredTestClass(),
+ Parameter.class,
+ (field) -> true,
+ HierarchyTraversalMode.BOTTOM_UP);
```
I think you might also need to update this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
