nastra commented on PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#issuecomment-2407180732
Rather than changing stuff everywhere, I'd probably consider changing how we
look up parameter providers:
```
--- a/api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java
+++ b/api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java
@@ -73,13 +73,10 @@ public class ParameterizedTestExtension implements
TestTemplateInvocationContext
// Search method annotated with @Parameters
final List<Method> parameterProviders =
AnnotationSupport.findAnnotatedMethods(
- context.getRequiredTestClass(), Parameters.class,
HierarchyTraversalMode.TOP_DOWN);
+ context.getRequiredTestClass(), Parameters.class,
HierarchyTraversalMode.BOTTOM_UP);
if (parameterProviders.isEmpty()) {
throw new IllegalStateException("Cannot find any parameter provider");
}
- if (parameterProviders.size() > 1) {
- throw new IllegalStateException("Multiple parameter providers are
found");
- }
```
@tomtongue can you please check with this diff how this affects the Junit
upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
