nastra commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1798896293
##########
spark/v3.5/build.gradle:
##########
@@ -303,6 +310,11 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
description = "Test Spark3 Runtime Jar against Spark ${sparkMajorVersion}"
group = "verification"
jvmArgs += project.property('extraJvmArgs')
+
+ // This flag is set to keep the backward compatibility between JUnit 5.10
and 5.11.
+ // Remove this after all Spark tests are migrated to JUnit 5.11.
+ // See https://github.com/apache/iceberg/issues/11296
+ jvmArgs += "-Djunit.platform.reflection.search.useLegacySemantics=true"
Review Comment:
See my latest on calling `TestBase.spark.close()` in subclasses, so I think
we don't need this legacy flag as it's usually better to fix how our testing is
configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
