tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1802491767
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Branch.java:
##########
@@ -46,12 +46,19 @@ public class TestFlinkIcebergSinkV2Branch extends
TestFlinkIcebergSinkV2Base {
private static final HadoopCatalogExtension CATALOG_EXTENSION =
new HadoopCatalogExtension(DATABASE, TestFixtures.TABLE);
- @Parameter(index = 0)
- private String branch;
+ @Parameter(index = 4)
+ protected String branch;
- @Parameters(name = "branch = {0}")
+ @Parameters(name = "branch = {4}")
Review Comment:
thanks so much for applying this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
