Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-11 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753546454 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java: ## @@ -1441,5 +1441,6 @@ public int hashCode() { public TypeSerializer

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753187076 ## baseline.gradle: ## @@ -74,8 +65,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/testFi

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753158715 ## baseline.gradle: ## @@ -74,8 +65,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/testFi

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
manuzhang commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753033356 ## baseline.gradle: ## @@ -74,8 +65,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/tes

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1752220687 ## baseline.gradle: ## @@ -65,7 +65,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/testFi

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1751994961 ## baseline.gradle: ## @@ -74,8 +65,7 @@ subprojects { spotless { java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/testFi

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-09-10 Thread via GitHub
nastra commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1751980378 ## build.gradle: ## @@ -28,7 +28,7 @@ buildscript { dependencies { classpath 'io.github.goooler.shadow:shadow-gradle-plugin:8.1.8' classpath 'com.palantir

Re: [PR] Build: Upgrade google-java-format to latest version [iceberg]

2024-08-31 Thread via GitHub
findepi commented on code in PR #11050: URL: https://github.com/apache/iceberg/pull/11050#discussion_r1739866418 ## baseline.gradle: ## @@ -50,16 +50,7 @@ subprojects { t.setDuplicatesStrategy(DuplicatesStrategy.WARN); }); apply plugin: 'com.palantir.baseline-exact-de