manuzhang commented on code in PR #11050:
URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753033356
##########
baseline.gradle:
##########
@@ -74,8 +65,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/testFixtures/java/**/*.java', 'src/jmh/java/**/*.java',
'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.23.0")
Review Comment:
I was going back and forth fixing format issues. `1.19.2` was released with
`spotless-plugin-gradle:6.25.0`. The error was weirdly reported on non-existent
codes.
```
You can use '--warning-mode all' to show the individual deprecation
warnings and determine if they come from your own scripts or plugins.
src/main/java/org/apache/iceberg/transforms/Transforms.java
@@ -67,7 +67,9 @@
····return·new·UnknownTransform<>(transform);
For more on this, please refer to
https://docs.gradle.org/8.10.1/userguide/command_line_interface.html#sec:command_line_warnings
in the Gradle documentation.
··}
25 actionable tasks: 25 executed
-··/**·@deprecated·use·{@link·#identity()}·instead;·will·be·removed·in·2.0.0·*/
+··/**
+···*·@deprecated·use·{@link·#identity()}·instead;·will·be·removed·in·2.0.0
+···*/
··@Deprecated
··public·static·Transform<?,·?>·fromString(Type·type,·String·transform)·{
····Matcher·widthMatcher·=·HAS_WIDTH.matcher(transform);
Run './gradlew :iceberg-api:spotlessApply' to fix these violations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
