findepi commented on code in PR #11050:
URL: https://github.com/apache/iceberg/pull/11050#discussion_r1739866418
##########
baseline.gradle:
##########
@@ -50,16 +50,7 @@ subprojects {
t.setDuplicatesStrategy(DuplicatesStrategy.WARN);
});
apply plugin: 'com.palantir.baseline-exact-dependencies'
- // We need to update Google Java Format to 1.17.0+ to run spotless on JDK 8,
but that requires dropping support for JDK 8.
- if (JavaVersion.current() == JavaVersion.VERSION_21) {
- task spotlessApply {
- doLast {
- throw new GradleException("Spotless plugin is currently disabled when
running on JDK 21 (until we drop JDK 8). To run spotlessApply please use a
different JDK version.")
- }
- }
Review Comment:
thank you!
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java:
##########
@@ -1441,5 +1441,6 @@ public int hashCode() {
public TypeSerializerSnapshot<CommittableMessage<IcebergCommittable>>
snapshotConfiguration() {
return null;
}
- };
+ }
+ ;
Review Comment:
looks off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
