nastra commented on code in PR #11050:
URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753158715
##########
baseline.gradle:
##########
@@ -74,8 +65,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/testFixtures/java/**/*.java', 'src/jmh/java/**/*.java',
'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.23.0")
Review Comment:
@manuzhang the issue is that spotless will pick a different gjf version
depending on the JDK it is executed with. Therefore you'll need to pin the gjf
to the latest version that is supported by JDK 11 to produce consistent
formatting results across JDK 11/17/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
