nastra commented on code in PR #11050:
URL: https://github.com/apache/iceberg/pull/11050#discussion_r1753187076
##########
baseline.gradle:
##########
@@ -74,8 +65,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/testFixtures/java/**/*.java', 'src/jmh/java/**/*.java',
'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.23.0")
Review Comment:
@manuzhang I did a quick experiment in
https://github.com/apache/iceberg/pull/11110 and we'll have to stick with
`1.17.0`. please make sure to re-introduce the comment from L77 so that it's
clear why we're using this particular gjf version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
