ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-3001829625
> @ForeverAngry Thank you for this feature ❤️
>
> Just one question/comment: It seems this only supports expiration
time/age, and does not support other [retention
greenlaw commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-3001581046
@ForeverAngry Thank you for this feature ❤️
Just one question/comment: It seems this only supports expiration time/age,
and does not support other [retention
policies]
Fokko commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2993003792
@ForeverAngry Appreciate that, thanks! 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2989230858
> @ForeverAngry I think we can move this one forward. Before the release, we
need to follow up on two things:
>
> - Add a new Maintenance doc section with a subsection t
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2989228382
> Thanks again @ForeverAngry for working on this 🚀
Thank you, for being such a supportive and inspiring member to work with!
--
This is an automated message from the
Fokko commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2989032298
@ForeverAngry I think we can move this one forward. Before the release, we
need to follow up on two things:
- Add a new Maintenance doc section with a subsection that explains
Fokko commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2989033112
Thanks again @ForeverAngry for working on this 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Fokko merged PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2988615287
> Thanks @ForeverAngry for working on this, and I think it is ready to go 👍
Great! I think @kevinjqliu is still listed as needing approval.
@kevinjqliu can you put you
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2964370134
I'm happy to follow the '.maintenance' api design if there is a strong
preference toward it.
--
This is an automated message from the Apache Git Service.
To respond to the m
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2140778886
##
pyiceberg/table/__init__.py:
##
@@ -1079,6 +1075,15 @@ def manage_snapshots(self) -> ManageSnapshots:
"""
return ManageSnapshots(transaction=T
Fokko commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2963723266
> I see that in https://github.com/apache/iceberg-python/pull/1958, for
orphaned file removal, we decided to have a table.maintenance API returning a
MaintenanceTable. As a user, if
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2140776136
##
pyiceberg/table/update/snapshot.py:
##
@@ -739,6 +741,7 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
ms.create_tag(snapshot_id1, "
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2963454826
Well, right now this pr doesn't do anything with the newly orphaned files.
It just handles the metadata operation.
--
This is an automated message from the Apache Git Servi
smaheshwar-pltr commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2962199625
I see that in https://github.com/apache/iceberg-python/pull/1958, for
orphaned file removal, we decided to have a `table.maintenance` API returning a
`MaintenanceTable`. As
zschumacher commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2960970720
this would be great - whats the status of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2888535189
> @ForeverAngry Sorry for the late reply, it looks like that there is a test
failing now 👀
I think this commit
[9031f06](https://github.com/apache/iceberg-python/pull/1
Fokko commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2887674853
@ForeverAngry Sorry for the late reply, it looks like that there is a test
failing now 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2869295350
> @ForeverAngry Could you see if you can get the linters/tests passing?
Thanks!
> @ForeverAngry Could you see if you can get the linters/tests passing?
Thanks!
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319399
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import S
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319496
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +85,10 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2083319196
##
tests/expressions/test_literals.py:
##
@@ -760,7 +760,6 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2075056092
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +85,10 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
-fr
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2075054632
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import Snapshot
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061325688
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import S
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061300464
##
tests/integration/test_partition_evolution.py:
##
@@ -140,6 +140,14 @@ def test_add_hour(catalog: Catalog) -> None:
_validate_new_partition_fields(t
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061298694
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061298441
##
tests/expressions/test_literals.py:
##
@@ -744,7 +744,7 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057650580
##
tests/integration/test_partition_evolution.py:
##
@@ -140,6 +140,14 @@ def test_add_hour(catalog: Catalog) -> None:
_validate_new_partition_fields(table, 1
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057645522
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
Review Comment:
```suggestion
# Licensed to the Apache Sof
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057644908
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
Review Comment:
The license is missing here
--
This is an
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057643193
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057102705
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +84,11 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057106903
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057105366
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053945584
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053939725
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053936271
##
pyiceberg/table/update/snapshot.py:
##
@@ -238,7 +244,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
previo
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053935050
##
tests/expressions/test_literals.py:
##
@@ -744,7 +744,7 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None:
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053934216
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +84,11 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
-fr
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053172440
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,52 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053170133
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
+from uuid import uuid4
+
+from pyiceberg.table import Com
kevinjqliu commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2051592966
##
.gitignore:
##
@@ -50,3 +50,5 @@ htmlcov
pyiceberg/avro/decoder_fast.c
pyiceberg/avro/*.html
pyiceberg/avro/*.so
+.vscode/settings.json
+pyiceberg/table
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2799746883
After looking at the way the action
[here](https://github.com/apache/iceberg-python/blob/15887011cb6bae9a4408eedc2824133efa3e1599/pyiceberg/table/update/__init__.py#L471)
was
ForeverAngry opened a new pull request, #1880:
URL: https://github.com/apache/iceberg-python/pull/1880
## Summary
This PR Closes issue #516 by implementing support for the `ExpireSnapshot`
table metadata action.
## Rationale
The `ExpireSnapshot` action is
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027638423
##
pyproject.toml:
##
@@ -83,6 +83,7 @@ cachetools = "^5.5.0"
pyiceberg-core = { version = "^0.4.0", optional = true }
polars = { version = "^1.21.0", opt
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027645539
##
pyiceberg/table/update/snapshot.py:
##
@@ -745,6 +763,8 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
def _commit(self) -> Up
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027643598
##
pyiceberg/table/update/snapshot.py:
##
@@ -239,7 +257,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027605325
##
pyiceberg/table/update/snapshot.py:
##
@@ -745,6 +763,8 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
def _commit(self) -> UpdatesAn
49 matches
Mail list logo
