Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2075056092
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +85,10 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
-fr
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2075054632
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import Snapshot
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061325688
##
pyiceberg/table/update/snapshot.py:
##
@@ -55,6 +55,7 @@
from pyiceberg.partitioning import (
PartitionSpec,
)
+from pyiceberg.table.refs import S
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061300464
##
tests/integration/test_partition_evolution.py:
##
@@ -140,6 +140,14 @@ def test_add_hour(catalog: Catalog) -> None:
_validate_new_partition_fields(t
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061298694
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2061298441
##
tests/expressions/test_literals.py:
##
@@ -744,7 +744,7 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057650580
##
tests/integration/test_partition_evolution.py:
##
@@ -140,6 +140,14 @@ def test_add_hour(catalog: Catalog) -> None:
_validate_new_partition_fields(table, 1
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057645522
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
Review Comment:
```suggestion
# Licensed to the Apache Sof
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057644908
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
Review Comment:
The license is missing here
--
This is an
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057643193
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057102705
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +84,11 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057106903
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2057105366
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053945584
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053939725
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,64 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method chaining
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053936271
##
pyiceberg/table/update/snapshot.py:
##
@@ -238,7 +244,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
previo
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053935050
##
tests/expressions/test_literals.py:
##
@@ -744,7 +744,7 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None:
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053934216
##
pyiceberg/table/update/snapshot.py:
##
@@ -82,7 +84,11 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
-fr
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053172440
##
pyiceberg/table/update/snapshot.py:
##
@@ -843,3 +849,52 @@ def remove_branch(self, branch_name: str) ->
ManageSnapshots:
This for method c
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053170133
##
tests/table/test_expire_snapshots.py:
##
@@ -0,0 +1,43 @@
+from unittest.mock import MagicMock
+from uuid import uuid4
+
+from pyiceberg.table import Com
kevinjqliu commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2051592966
##
.gitignore:
##
@@ -50,3 +50,5 @@ htmlcov
pyiceberg/avro/decoder_fast.c
pyiceberg/avro/*.html
pyiceberg/avro/*.so
+.vscode/settings.json
+pyiceberg/table
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2799746883
After looking at the way the action
[here](https://github.com/apache/iceberg-python/blob/15887011cb6bae9a4408eedc2824133efa3e1599/pyiceberg/table/update/__init__.py#L471)
was
ForeverAngry opened a new pull request, #1880:
URL: https://github.com/apache/iceberg-python/pull/1880
## Summary
This PR Closes issue #516 by implementing support for the `ExpireSnapshot`
table metadata action.
## Rationale
The `ExpireSnapshot` action is
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027638423
##
pyproject.toml:
##
@@ -83,6 +83,7 @@ cachetools = "^5.5.0"
pyiceberg-core = { version = "^0.4.0", optional = true }
polars = { version = "^1.21.0", opt
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027645539
##
pyiceberg/table/update/snapshot.py:
##
@@ -745,6 +763,8 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
def _commit(self) -> Up
ForeverAngry commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027643598
##
pyiceberg/table/update/snapshot.py:
##
@@ -239,7 +257,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027605325
##
pyiceberg/table/update/snapshot.py:
##
@@ -745,6 +763,8 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
def _commit(self) -> UpdatesAn
27 matches
Mail list logo
