Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2053936271
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -238,7 +244,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
previous_summary=previous_snapshot.summary if previous_snapshot is
not None else None,
)
- def _commit(self) -> UpdatesAndRequirements:
+ def _commit(self, base_metadata: TableMetadata) -> UpdatesAndRequirements:
Review Comment:
I don't think this change is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
