Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2140778886
##########
pyiceberg/table/__init__.py:
##########
@@ -1079,6 +1075,15 @@ def manage_snapshots(self) -> ManageSnapshots:
"""
return ManageSnapshots(transaction=Transaction(self, autocommit=True))
+ def expire_snapshots(self) -> ExpireSnapshots:
+ """
+ Shorthand to run expire snapshots by id or by a timestamp.
+
+ Use table.expire_snapshots().<operation>().commit() to run a specific
operation.
+ Use
table.expire_snapshots().<operation-one>().<operation-two>().commit() to run
multiple operations.
Review Comment:
I believe this isn't true, since the method returns `ExpireSnapshots`,
meaning that you cannot chain the operations (which is fine if you call it on
the table).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
