Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2027605325
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -745,6 +763,8 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
+ if not hasattr(self._transaction, "_apply"):
+ raise AttributeError("Transaction object is not properly
initialized.")
Review Comment:
I don't think this should happen. Did you run into this?
##########
pyproject.toml:
##########
@@ -83,6 +83,7 @@ cachetools = "^5.5.0"
pyiceberg-core = { version = "^0.4.0", optional = true }
polars = { version = "^1.21.0", optional = true }
thrift-sasl = { version = ">=0.4.3", optional = true }
+daft = "^0.4.8"
Review Comment:
Do we need this dependency?
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -239,7 +257,7 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
truncate_full_table=self._operation == Operation.OVERWRITE,
)
- def _commit(self) -> UpdatesAndRequirements:
+ def commit(self, base_metadata: TableMetadata) -> UpdatesAndRequirements:
Review Comment:
```suggestion
def _commit(self, base_metadata: TableMetadata) ->
UpdatesAndRequirements:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
